Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close readline in StdinDiscarder without changing stdin's pause state #210

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Jun 24, 2022

Patches the close in StdinDiscarder to keep stdin unpaused if it was already in that state. readline.close() has the undocumented side-effect of pausing the input stream, in this case stdin.

Fixes #209.

@sindresorhus sindresorhus merged commit 77ccc1e into sindresorhus:main Jun 26, 2022
sindresorhus added a commit that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdin becomes paused at close only when using StdinDiscarder with TTY
2 participants